You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on May 5, 2026. It is now read-only.
I've created forwardWithCallback() in the style of mockWithCallback(), tried to make as minimal change as possible, could reuse some of the code in createExpectationWithCallback but opted to keep it all separate
The only difference in contract with mockWithCallback() is the requestAndResponseHandler, which if present triggers responseCallback: true. Don't know if there are other scenarios other than replying an HttpRequest and then a HttpResponse to the websocket but I can implement them if needed
If approach is approved I can look into testing and later updating the docs for the javascript example
Thank you for this contribution @pedrorfernandes! As part of consolidating MockServer into a monorepo, we're deferring feature PRs that need additional review, testing, and documentation. We'd love to have this forwardWithCallback feature - would you be willing to re-submit this PR against the monorepo at https://github.com/mock-server/mockserver once the consolidation is complete? We're happy to work with you on getting tests and documentation added. The monorepo migration is currently in progress.
This feature request is now tracked in the main monorepo. Feel free to contribute there once the monorepo consolidation is complete!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've created
forwardWithCallback()in the style ofmockWithCallback(), tried to make as minimal change as possible, could reuse some of the code increateExpectationWithCallbackbut opted to keep it all separateThe only difference in contract with
mockWithCallback()is therequestAndResponseHandler, which if present triggersresponseCallback: true. Don't know if there are other scenarios other than replying an HttpRequest and then a HttpResponse to the websocket but I can implement them if neededIf approach is approved I can look into testing and later updating the docs for the javascript example